Skip to content

DFBUGS-4690: Add new metrics and alert when CG is enabled on DRPC #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agarwal-mudit merged 2 commits into from
Nov 19, 2025
Merged

DFBUGS-4690: Add new metrics and alert when CG is enabled on DRPC #663

agarwal-mudit merged 2 commits into from
Nov 19, 2025

Conversation

@rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Nov 19, 2025 •
edited
Loading

This PR adds new metric and alert to inform the user that unsupported consistency grouping is enabled

  • Metric: unsupported_consistency_grouping_enabled on DRPC.
    This metric indicates whether consistency grouping (CG) is enabled for a DRPC:

    • 0 (disabled): CG enabled annotation is missing or set to "false"
    • 1 (enabled): CG enabled annotation is present and set to "true"

  • Alert: UnsupportedConsistencyGroupingEnabled
    This alert monitors the ramen_unsupported_consistency_grouping_enabled metric and raises a warning alert when the value is 1, indicating that unsupported consistency grouping is enabled for the DRPC.

cherry-picked from RamenDR#2343

@rakeshgm
Add new metric when CG is enabled
9d78e6f 
ramen_unsupported_consistency_grouping_enabled
This metric indicates whether consistency group protection (CG) is
enabled for a DRPC:
- 0 (disabled): CG enabled annotation is missing or set to "false"
- 1 (enabled): CG enabled annotation is present and set to "true"

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 1892c12)
@rakeshgm
New alert: UnsupportedConsistencyGroupingEnabled
cfbfe26 
This alert monitors the "ramen_unsupported_consistency_grouping_enabled"
metric and raises a warning alert when the value is 1, indicating
that unsupported consistency grouping is enabled for the DRPC.

Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit c68f0c8)
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rakeshgm

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rakeshgm rakeshgm changed the title Add new metrics and alert when CG is enabled on DRPC DFBUG-4690: Add new metrics and alert when CG is enabled on DRPC Nov 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

@rakeshgm: No Jira issue with key DFBUG-4690 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

This PR adds new metric and alert to inform the user that unsupported consistency grouping is enabled

  • Metric: unsupported_consistency_grouping_enabled on DRPC.
    This metric indicates whether consistency grouping (CG) is enabled for a DRPC:

    • 0 (disabled): CG enabled annotation is missing or set to "false"
    • 1 (enabled): CG enabled annotation is present and set to "true"

  • Alert: UnsupportedConsistencyGroupingEnabled
    This alert monitors the ramen_unsupported_consistency_grouping_enabled metric and raises a warning alert when the value is 1, indicating that unsupported consistency grouping is enabled for the DRPC.

cherry-picked from RamenDR#2341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rakeshgm rakeshgm changed the title DFBUG-4690: Add new metrics and alert when CG is enabled on DRPC DFBUGS-4690: Add new metrics and alert when CG is enabled on DRPC Nov 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025 •
edited by openshift-ci bot
Loading

@rakeshgm: This pull request references [Jira Issue DFBUGS-4690](https://issues.redhat.com//browse/DFBUGS-4690), which is invalid:

  • expected the bug to target the "odf-4.20" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This PR adds new metric and alert to inform the user that unsupported consistency grouping is enabled

  • Metric: unsupported_consistency_grouping_enabled on DRPC.
    This metric indicates whether consistency grouping (CG) is enabled for a DRPC:

    • 0 (disabled): CG enabled annotation is missing or set to "false"
    • 1 (enabled): CG enabled annotation is present and set to "true"

  • Alert: UnsupportedConsistencyGroupingEnabled
    This alert monitors the ramen_unsupported_consistency_grouping_enabled metric and raises a warning alert when the value is 1, indicating that unsupported consistency grouping is enabled for the DRPC.

cherry-picked from RamenDR#2341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agarwal-mudit agarwal-mudit merged commit 0390b66 into red-hat-storage:release-4.20 Nov 19, 2025
21 of 23 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025 •
edited by openshift-ci bot
Loading

@rakeshgm: [Jira Issue DFBUGS-4690](https://issues.redhat.com//browse/DFBUGS-4690): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-4690](https://issues.redhat.com//browse/DFBUGS-4690) has been moved to the MODIFIED state.

Details

In response to this:

This PR adds new metric and alert to inform the user that unsupported consistency grouping is enabled

  • Metric: unsupported_consistency_grouping_enabled on DRPC.
    This metric indicates whether consistency grouping (CG) is enabled for a DRPC:

    • 0 (disabled): CG enabled annotation is missing or set to "false"
    • 1 (enabled): CG enabled annotation is present and set to "true"

  • Alert: UnsupportedConsistencyGroupingEnabled
    This alert monitors the ramen_unsupported_consistency_grouping_enabled metric and raises a warning alert when the value is 1, indicating that unsupported consistency grouping is enabled for the DRPC.

cherry-picked from RamenDR#2341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025 •
edited by openshift-ci bot
Loading

@rakeshgm: [Jira Issue DFBUGS-4690](https://issues.redhat.com//browse/DFBUGS-4690) is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

This PR adds new metric and alert to inform the user that unsupported consistency grouping is enabled

  • Metric: unsupported_consistency_grouping_enabled on DRPC.
    This metric indicates whether consistency grouping (CG) is enabled for a DRPC:

    • 0 (disabled): CG enabled annotation is missing or set to "false"
    • 1 (enabled): CG enabled annotation is present and set to "true"

  • Alert: UnsupportedConsistencyGroupingEnabled
    This alert monitors the ramen_unsupported_consistency_grouping_enabled metric and raises a warning alert when the value is 1, indicating that unsupported consistency grouping is enabled for the DRPC.

cherry-picked from RamenDR#2343

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShyamsundarR ShyamsundarR Awaiting requested review from ShyamsundarR ShyamsundarR is a code owner

@BenamarMk BenamarMk Awaiting requested review from BenamarMk BenamarMk is a code owner

Assignees

No one assigned

Labels

jira/invalid-bug jira/valid-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rakeshgm @openshift-ci-robot @agarwal-mudit